Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

feat:2376: Check compatibility with sdk34, allows use on android above sdk33.

Guillaume Jacquart requested to merge 2376-Android_14_compatibility into main

Description

This MR prepare AdvancedPrivacy for Android 14 (codename 'u' ; sdk 34)

AdvancedPrivacy use private API from android framework. It implies taht we can't rely on compilator or warning for correct use of this API, specificaly in the case of new Android version, with API upgrade. To mitigate this risk, we explicitely redeclare the private API we use in the module :permissionseos:libs:hidden-apis-stub' . It allows us to avoid reflection, and to document (with a simple check in the corresponding source code in android_framework_base project) availability of hidden APIs, depending on sdk version.

Screenshots

No changes.

Technical details

There wasn't any visible change in the hidden API we use ; but we was explicitely failing early on android sdk > 33 . This rule is removed here.

Tests

No regressions on Android 12 ;

Tested on a FP3 with in progress /e/ V1-u .

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/2376

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

  • New Features

    • Updated target SDK to 34, enabling access to the latest Android features.
    • Enhanced dependency versions for improved performance and bug fixes, including androidx_core and orbotservice.
  • Documentation

    • Updated deprecation messages and guidelines in various classes to reflect new API standards, improving clarity for developers.
  • Refactor

    • Simplified conditional logic in the permissions module for better code efficiency.
Edited by CodeRabbitAI

Merge request reports

Loading