Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

1964: add thousand separators on leaks counts.

Guillaume Jacquart requested to merge 1964-thousand_separator into main

Description

What is the current behavior?

On any screen in Advanced Privacy the number of leaks is displayed without formatting which make big figures difficult to read.

What is the improved behavior?

On each screen where the number of leaks is displayed, the number if formatted with a thousand separator. The thousand separator depending on the language (e.g. , in English, space in French) so this separator needs to adapt to the language selected by the user.

Screenshots

Screenshot_20240313_200651 Screenshot_20240313_200757

Screenshot_20240313_200856 Screenshot_20240313_202954

Technical details

The methods used requires sdk30 (android 11 - R) as minimum. As it is now the minimum version supported by /e/OS, the minSdk value has been updated.

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/1964

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Guillaume Jacquart

Merge request reports

Loading