Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

1465 graph period

Guillaume Jacquart requested to merge 1465-graph_period into main

Description

There is time range selector that enables the user to choose on which period of time they want to see the graph of blocked and allowed leaks: day, month or year.
This time range selector also impacts the stats displayed in the subtitles of the app or tracker name in the second part of the screen (cf. https://gitlab.e.foundation/e/os/backlog/-/issues/1203). The time range selected by the user is saved for the next time the user opens the screen.

Screenshots

Screenshot_20231226-171411_Advanced_Privacy_3 Screenshot_20231226-171354_Advanced_Privacy_3 Screenshot_20231226-170506_Advanced_Privacy_3

Technical details

  • All the screen below the day-month-year tabs is a pager, so it involve a few changes.
  • it means that this view as two imbricated pager, in a scrollview and with a recycler view in the deeper pager : the "fix pager height" hack is needded for both pagers.
  • the Graph library as a limit of 25 graduations on X-axis, as a workaround, the Month graph as a graduation only each 2 days.

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/1465

10 commandments of code reviews

👪 ❤ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Guillaume Jacquart

Merge request reports