Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

1222: tight toggle feature to UI switch state.

Guillaume Jacquart requested to merge 1222-features_switch_wrong_state into main

Description

When we switch off the Ip spoofing randomly the switch stay in ON position while the lable is updated and it mentioned that the service is OFF.

Screenshots

Technical details

I didn't reproduce the behavior, but I find a crash in the native Tor libraries, while monkey tapping the hide my ip switch

Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 2553 (tor), pid 2432 (advancedprivacy)

This MR attemps to avoid the behavior on the screenshot, tightening the UI switch state to the features states ; And add delay after stopping orbot, to show the user that it should be toggled with care. But still with the 1s delay, I encounter the crash after 5 -10 switch ON <-> OFF <-> ON

Tests

Toggle quickly the Hide My Ip switch.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/1222

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Merge request reports

Loading