Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Complete polygon stroke

Fynn Godau requested to merge epic67-fix-incomplete-polygon-stroke into master

Description

When testing the style, I noticed that polygon lines were not complete iff the app's polygon did not specify the polygon to be closed – which it need not per docs:

It is not necessary for the start and end points to coincide; if they do not, the polygon will be automatically closed.

Screenshots

emmy app

Before After
polygonlinemissing polygonlinepresent

Technical details

The expression (holePoints + holePoints.firstOrNull()).filterNotNull() adds the first point at the end of the list, provided that there are any points at all to avoid a NoSuchElementException.

Tests

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Merge request reports

Loading