Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Call `onStart()` right before taking snapshot

Fynn Godau requested to merge 912-snapshot-onstart into master

Description

Signal does not call onStart on the map that takes the snapshot.

There is still more problems with sharing location in Signal, though those are not really related to snapshots not working – see my explanations in https://gitlab.e.foundation/e/os/backlog/-/issues/1169.

Screenshots

snapshotinsignal

Technical details

Signal does not to call onStart() on the map that is snapshot, probably this was forgotten as onCreate() and onResume() are both called in sequence. Because onStart() is not called, snapshots do not work

Tests

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Merge request reports

Loading