Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Use MapLibre

Fynn Godau requested to merge 907-maplibre into master

Move from MapBox SDK to MapLibre SDK.

Description

From user perspective this MR should change nothing, except when pressing the (i) button on a Google Maps / "mapbox" map:

  • popup may have has a changed heading in your language to reflect that MapLibre is used¹
  • no "Telemetry Settings" option

Note that the "mapbox" watermark itself was not changed in MapLibre.

For the next MapLibre version, the dialog title will also be changed.

¹ Even though the changelog in https://github.com/maplibre/maplibre-gl-native/releases/tag/android-v9.5.2 appears indicate that this was indeed changed, https://github.com/maplibre/maplibre-gl-native/pull/160/ only covers the localized string resources. The English original at https://github.com/maplibre/maplibre-gl-native/blob/2478d54261908711cbea89de4d4212917e021f9f/platform/android/MapboxGLAndroidSDK/src/main/res/values/strings.xml#L7 is only changed in a commit that is not included in the latest version. A release is supposed to be coming soon now here!

Screenshots

(style differences re. rounded corners are due to different Android versions)

before after
Screenshot_20221215-154724 Screenshot_1671459008

(On an older version of the screenshot, the heading was invisible in the Newer version and I was still wondering why. This was simply caused by a custom ROM screwing with the styles badly.)

Technical details

Very few changes had to be made for this – only minor API changes compared to MapBox SDK are present.

Reading the maplibre Android changelog also did not reveal any breaking changes.

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Edited by Fynn Godau

Merge request reports

Loading