Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 681f340d authored by Riddle Hsu's avatar Riddle Hsu
Browse files

Finish recents animation for standalone recents on home 

There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.

Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.

Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.

Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.

This can also fix various issues when using a 3p launcher:
 - When auto rotation is enabled and put device in landscape:
    - Unable to enter recents from gesture mode
    - System bars are disappeared when pressing recents key
 - Jump-cut when pressing home key to leave recents on home.

Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
      The app should not receive onPause.
Change-Id: I9ba9bdb3757bbdcb1cbb363b4fe6431860dac4da
parent 9633e5b7

quickstep/src/com/android/quickstep/TaskAnimationManager.java

+21 −10
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ import static com.android.launcher3.util.Executors.MAIN_EXECUTOR; 
import static com.android.launcher3.util.Executors.UI_HELPER_EXECUTOR;

import static com.android.launcher3.util.NavigationMode.NO_BUTTON;

import static com.android.quickstep.GestureState.GestureEndTarget.RECENTS;

import static com.android.quickstep.GestureState.STATE_END_TARGET_ANIMATION_FINISHED;

import static com.android.quickstep.GestureState.STATE_RECENTS_ANIMATION_INITIALIZED;

import static com.android.quickstep.GestureState.STATE_RECENTS_ANIMATION_STARTED;

import static com.android.quickstep.util.ActiveGestureErrorDetector.GestureEvent.START_RECENTS_ANIMATION;
@@ -40,7 +41,6 @@ import com.android.launcher3.Utilities; 
import com.android.launcher3.config.FeatureFlags;

import com.android.launcher3.testing.shared.TestProtocol;

import com.android.launcher3.util.DisplayController;

import com.android.quickstep.TopTaskTracker.CachedTaskInfo;

import com.android.quickstep.util.ActiveGestureLog;

import com.android.quickstep.views.RecentsView;

import com.android.systemui.shared.recents.model.ThumbnailData;
@@ -154,6 +154,24 @@ public class TaskAnimationManager implements RecentsAnimationCallbacks.RecentsAn 
                    mLastAppearedTaskTargets[i] = task;

                }

                mLastGestureState.updateLastAppearedTaskTargets(mLastAppearedTaskTargets);



                if (ENABLE_SHELL_TRANSITIONS && mTargets.hasRecents

                        // The filtered (MODE_CLOSING) targets only contain 1 home activity.

                        && mTargets.apps.length == 1

                        && mTargets.apps[0].windowConfiguration.getActivityType()

                        == ACTIVITY_TYPE_HOME) {

                    // This is launching RecentsActivity on top of a 3p launcher. There are no

                    // other apps need to keep visible so finish the animating state after the

                    // enter animation of overview is done. Then 3p launcher can be stopped.

                    mLastGestureState.runOnceAtState(STATE_END_TARGET_ANIMATION_FINISHED, () -> {

                        // Only finish if the end target is RECENTS. Otherwise, if the target is

                        // NEW_TASK, startActivityFromRecents will be skipped.

                        if (mLastGestureState.getEndTarget() == RECENTS) {

                            finishRunningRecentsAnimation(false /* toHome */,

                                    true /* forceFinish */, null /* forceFinishCb */);

                        }

                    });

                }

            }



            @Override
@@ -256,15 +274,8 @@ public class TaskAnimationManager implements RecentsAnimationCallbacks.RecentsAn 


        if (ENABLE_SHELL_TRANSITIONS) {

            final ActivityOptions options = ActivityOptions.makeBasic();

            // Allowing to pause Home if Home is top activity and Recents is not Home. So when user

            // start home when recents animation is playing, the home activity can be resumed again

            // to let the transition controller collect Home activity.

            CachedTaskInfo cti = gestureState.getRunningTask();

            boolean homeIsOnTop = cti != null && cti.isHomeTask();

            if (activityInterface.allowAllAppsFromOverview()) {

                homeIsOnTop = true;

            }

            if (!homeIsOnTop) {

            // Use regular (non-transient) launch for all apps page to control IME.

            if (!activityInterface.allowAllAppsFromOverview()) {

                options.setTransientLaunch();

            }

            options.setSourceInfo(ActivityOptions.SourceInfo.TYPE_RECENTS_ANIMATION, eventTime);