Fixed optional overflow crash by verifying the presence of bubbles.
The scenario where "A bubble was added from the overflow (and now it's empty/not showing)" lacked a check to verify if bubbles are currently present. Its absence caused calls to removeOverflowAndAddBubble() of BubbleBarViewController for any first bubble matching the previously closed last bubble, not just those added from the overflow. This CL addresses the issue by adding the missing check. Test: Manual. Set enable_optional_bubble_overflow flag to true. Create one bubble, dismiss it, create the same bubble again. Create another bubble, dismiss it, open overflow and click on dismissed bubble. Observe the overflow icon disappears. Video: http://recall/-/gx8ASgewUeUS3QYohfrd1J/eYeyo6cNeUBw4mU6rrkXtN Flag: com.android.wm.shell.enable_bubble_bar Fixes: 373940143 Change-Id: I4085ce4e922e2b5d65466a00649dda086c14185f
Loading
Please register or sign in to comment