Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e91646d authored by Luca Zuccarini's avatar Luca Zuccarini
Browse files

Animate depth from the right value on Taskbar All Apps launches. 

`MyDepthController` in `QuickstepTransitionLauncher` assumes that we
want the background to always animate the same way, matching the rest
state of the workspace (depth == 0). However, in Taskbar All Apps the
background is visible, and depth != 0. We now initialize the one-off
`DepthController` for launches to take into account the latest depth set
by the top level `DepthController`, so there is no jumpcut at the
beginning of the animation.

Note that in my opinion we should use the same `DepthController` for all
cases, rather than having this one-off. I'm looking into the feasibility
of that change, but for now this fixes the issue at hand.

Fix: 292959100
Flag: N/A
Test: manual, see videos in the bug

Change-Id: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
(cherry picked from commit 627d6754)
parent 2b3dc6f7

quickstep/src/com/android/launcher3/QuickstepTransitionManager.java

+7 −4
Original line number Original line Diff line number Diff line
@@ -1046,7 +1046,7 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener 
        boolean allowBlurringLauncher = mLauncher.getStateManager().getState() != OVERVIEW

        boolean allowBlurringLauncher = mLauncher.getStateManager().getState() != OVERVIEW

                && BlurUtils.supportsBlursOnWindows();

                && BlurUtils.supportsBlursOnWindows();





        MyDepthController depthController = new MyDepthController(mLauncher);

        LaunchDepthController depthController = new LaunchDepthController(mLauncher);

        ObjectAnimator backgroundRadiusAnim = ObjectAnimator.ofFloat(depthController.stateDepth,

        ObjectAnimator backgroundRadiusAnim = ObjectAnimator.ofFloat(depthController.stateDepth,

                        MULTI_PROPERTY_VALUE, BACKGROUND_APP.getDepth(mLauncher))

                        MULTI_PROPERTY_VALUE, BACKGROUND_APP.getDepth(mLauncher))

                .setDuration(APP_LAUNCH_DURATION);

                .setDuration(APP_LAUNCH_DURATION);
@@ -2047,11 +2047,14 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener 
        }

        }

    }

    }





    private static class MyDepthController extends DepthController {

    private static class LaunchDepthController extends DepthController {

        MyDepthController(Launcher l) {

        LaunchDepthController(QuickstepLauncher launcher) {

            super(l);

            super(launcher);

            setCrossWindowBlursEnabled(

            setCrossWindowBlursEnabled(

                    CrossWindowBlurListeners.getInstance().isCrossWindowBlurEnabled());

                    CrossWindowBlurListeners.getInstance().isCrossWindowBlurEnabled());

            // Make sure that the starting value matches the current depth set by the main

            // controller.

            stateDepth.setValue(launcher.getDepthController().stateDepth.getValue());

        }

        }

    }

    }

}
 
}