Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Fix: shortcuts messing up with the grid

Amit Kumar requested to merge hotfix/shortcut-deletion-issue into master

Description

This MR is intended to fix a bug that messes up the icon grid when the user adds any second shortcut.

Related issues

e/backlog#806 (closed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related MRs

How has this been tested?

How to reproduce (deletion of the other shortcuts):

  1. Open Browser
  2. Add a webpage to the home screen from the menu
  3. Re-open the browser
  4. Add another web page to the home screen from the menu -> The first shortcut has been removed and you will see only the newer shortcut

How to reproduce (deletion of the other apps):

  1. Open Browser
  2. Add a webpage to the home screen from the menu
  3. Create a new folder with the shortcut and any other app
  4. Re-open the browser
  5. Add another web page to the home screen from the menu -> The folder (with the "old" shortcut and the other app) has been removed and you will see only the newer shortcut

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Edited by Romain Hunault

Merge request reports

Loading