Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

show a dialog after unlock to allow notification permissions

Yash Garg requested to merge 5987-master-fix_notif_dots into master

Description

After the user upgrades from an old build to a new build, we will show a dialog asking the user for providing the notification access permission for enabling notification dots (as it is not enabled without a clean flash .

There are two options on the dialog, Ignore and Grant. Pressing Ignore will simply close the dialog and won't show up again, whereas Grant will take the user to the relevant screen which can be seen in the video below.

This is a better and proper way of fixing this issue without requiring any hacky changes like https://gitlab.e.foundation/e/os/android_frameworks_base/-/merge_requests/130.

Screenshots

upgrade-boot

Tests

  • If notification access is disabled in launcher before upgrading
  • After upgrading, the dialog is shown with two action buttons specified above
  • Pressing "Ignore" will dismiss the dialog and won't show up again (can test after force stopping or rebooting the device)
  • Pressing "Grant" will open the settings screen highlighting BlissLauncher (to provide permission)

Issues

https://gitlab.e.foundation/e/backlog/-/issues/5987#note_286239

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Edited by Yash Garg

Merge request reports

Loading