Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

1981-handle retry & notification on network issue

Description

Sometimes syncs are called when no network is available. For these cases, error notifications are thrown. Which are confusing for users. We don't want to show notifications for these cases.

Again when the server is not available, there are multiple notifications for sync issues. We want to show a single notification per account, not per sync failure.

Again, when an exception occurs, we want to retry performing the sync with the Fibonacci series as wait-time as wait-times (ex: 5, 8, 13, 21secs to wait next retry).

Screenshots

Technical details

Sometimes sync is kicked in when no network is not available. Or sync is scheduled & kicked just the time network becomes available but not ready; in this case, it throws ConnectException. In these cases, we don't want to show notifications to users.

Tests

  • Disable network connection
  • Called force sync for murena/google account from /e/OS Settings
  • check no notification is popped up

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Edited by Fahim Salam Chowdhury

Merge request reports

Loading