Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

746-Stop_login_on_unAuthorize_response_for_murena_accounts

Description

On the wrong username/password, murena account authentication takes too much time to detect the failure. This MR improves the time requires to detect failure.

Screenshots

screen-20221026-170514

Technical details

As for the wrong username, and password in the login flow; the backend response with 401. But DavResource ignores them for CALDAV & CARDDAV configuration fetch. As murena accounts have both of them set up, we want to block login for 401 on munrena account setup. So users have a faster response on 401.

Tests

  • Try to log in with murena account with a username & wrong password. After ~5 seconds the popup is shown that the login failed. After trying to log in with the correct credentials, the login success took ~20 sec.

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Merge request reports

Loading