Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

provide a way to listen for account remove callback from background; unify permissions across adding and removing account.

dev-12 requested to merge 3705-a15-account-removed-fixes into main

Description

changes required to migrate our other apps to in house account added and removed broadcast.

Technical details

We have migrated our mail app to use an in-house broadcast implementation instead of the system one.
Our custom implementation is more robust and handles edge cases more effectively.
This change lays the foundation for migrating our other apps to use our custom broadcast as well.

Tests

manually tested by adding and removing account. see testing in AccountManager#176

Issues

see 3705

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability of notifications sent to mail apps after account creation and removal, reducing missed or delayed updates across devices and OS versions.
  • Refactor
    • Internal account-notification mechanism updated and simplified, removing legacy behavior for easier maintenance and fewer edge-case failures.
Edited by CodeRabbitAI

Merge request reports

Loading