Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fix: add support for re-authentication in Murena account settings

Fahim M. Choudhury requested to merge 3377-murena-oauth-re-authenticate into main

Description

With SSO-enabled Account Manager, there was no way to reauthenticate a Murena account using OAuth and SSO. (Refer to the issue for screen record.)

This MR enables the user to reauthenticate a Murena account using OAuth.

Screenshots

image

Technical details

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/3377

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Summary by CodeRabbit

  • New Features

    • Improved account setup and re-authentication flows by providing additional context, such as account name hints and re-authentication status, during login and account addition.
  • Refactor

    • Simplified and centralized account selection and creation logic for easier maintenance.
    • Streamlined login blocking and authentication checks for better code clarity and consistency.
  • Bug Fixes

    • Enhanced handling of re-authentication scenarios to ensure smoother user experience during account updates or migrations.
Edited by CodeRabbitAI

Merge request reports

Loading