Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

3293-Improve_code_quality

Fahim Salam Chowdhury requested to merge 3293-Improve_code_quality into main

Description

Improve checking on setting authState.

Screenshots

Technical details

Tests

Issues

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Summary by CodeRabbit

  • Bug Fixes

    • Improved validation across multiple areas to treat blank (whitespace-only) strings as invalid for credentials, tokens, and URLs, enhancing security and preventing errors.
    • Tightened checks for user input fields, authentication state, and access tokens to ensure only meaningful, non-blank values are processed.
  • Chores

    • Updated a library dependency to a newer version.
    • Removed redundant variable declarations to streamline internal logic.
Edited by CodeRabbitAI

Merge request reports

Loading