Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Draft: feature: Notify user to switch to OpenId with Service

Vincent Bourgmayer requested to merge 2097-notify-move-to-openId2 into main

Description

Post a notification when device boot and if there is a murena account registered with password, to let the user switch to OpenID implementation.

Screenshots

Technical details

previous MR used a Activity without setContentView(). so no UI for the activity. But it got rejected. I have suggested to use a service instead.

Main issue was that AccountManager.removeAccoutnExplicitely & AccountManager.addAccount doesn't accept a Service as a parameter. It expects an Activity or null. But if null is provide, it just return an intent to start from the service.

However, it's not a good practice to start an Activity from a Service.

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/2097

10 commandments of code reviews

👪 ❤️ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced several new sync adapter services for enhanced account synchronization, including support for Murena and Google accounts.
    • Added a new service for re-login using OpenID Connect, improving account management.
    • New notifications to inform users about account management and new login options, including prompts to switch to OpenID for a better experience.

  • Bug Fixes

    • Improved account management logic to handle synchronization more robustly after device reboots.

  • Documentation

    • Added new string resources for notifications to enhance user experience.
Edited by Vincent Bourgmayer

Merge request reports