Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Enable OIDC support for murena.io account

Fahim Salam Chowdhury requested to merge 6287-Enable_murena_OIDC_support into main

Description

Enable OIDC support for murena.io accounts, so we can use SSO via OIDC in /e/OS. Affected apps: /e/OS Account Manager, /e/OS Calendar, /e/OS Contacts, /e/OS Notes, /e/OS Tasks, /e/OS Mail, eDrive.

Screenshots

Technical details

  • Remove clientSecret support as we are going to onky use PKCE as suggested by community (ex: https://www.oauth.com/oauth2-servers/pkce/).
  • Fix Some resource clearing caused app to crash issue.
  • update flag value of OIDC for murena.io apps.

Tests

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

Release Notes

  • New Features

    • OpenID support is now enabled in the application, enhancing authentication options.
  • Bug Fixes

    • Improved error handling during resource disposal across several components, preventing potential crashes and ensuring smoother operation.
  • Chores

    • Updated CI/CD pipeline configuration for better security practices and dependency management.
    • Removed sensitive information handling from build configurations.

These changes collectively enhance the application's stability, security, and user authentication capabilities.

Edited by CodeRabbitAI

Merge request reports

Loading