Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

feat: add flag to detect authFailure on performSync stage

Description

When user change password on cloud side, then the device with the murena account, must display a notification to inform user that he must update his credentials. When taping on the notification, it must open settings to let user quickly update credentials.

Please follow https://conventionalcomments.org/ in your review

Screenshots

screen record notifPasswordChanged6

One current remaining issue, is we may get many notification for the same purpose, because it is triggered for each elements to sync : contact, calendars, etc... Fixed

screenshot Screenshot_20240724-113657_Account_Manager

Technical details

Tests

  1. Add a valid murena account on the device
  2. Let run for a little more than 24hours, in order to check we don't get the notification for expired session
  3. Then open murena account in browser
  4. Change the password
  5. wait for notification to appear and/or, manually trigger notification from account's setting on the device.
  6. Check the notification, tap on it, it must open the account settings to allow to update the password
  7. Update password on device
  8. swipe the previous notification if still there
  9. Wait: no notification should appear again

Also check that you don't get the new notification twice at the same time

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

  • New Features

    • Introduced enhanced error handling and notifications for unauthorized access during synchronization.
    • Added personalized error messages for authentication failures, improving user feedback.
  • Bug Fixes

    • Improved logging during synchronization processes to track errors and successes more effectively.
  • Chores

    • Enhanced logging capabilities to provide better visibility into synchronization initiation and completion.
Edited by CodeRabbitAI

Merge request reports

Loading