6584-Refactor_openId_signIn_flow
Description
Current openId support implementation is tightly coupled with Google authentication flow. To support other openId authentication (ex: yahoo, AOL, etc) we need to first refactor the current openId implementation so, we have an easier implementation flow in the future.
Screenshots
Technical details
- Abstract out openId login implementation from googleAuthFragment, so we can re-use it later.
- Add missing clientSecret in openId authentication flow for providers who support clienSecret.
- Move out openId clientId values from being hardcoded inside the project to be passed by GitLab CI on the build flow. The items will be fetched from the project's local.properties file.
- Refactor syncAdapterService classes, as same types of them do have the same implementation but we need to have separate classes. So instead of copy-pasting the same code in multiple places, extend one implementation as the base class.
Tests
Check after login with murena & google account in /e/OS Account Manager, all sync works are done perfectly.
Issues
10 Commandments of code reviews
Edited by Fahim Salam Chowdhury