Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ca97328 authored by Fahim Salam Chowdhury's avatar Fahim Salam Chowdhury 👽
Browse files

fix: flow leak on SsoGrantActivity by binding with lifeCycle

parent a9f52972

app/src/main/java/com/owncloud/android/ui/activity/SsoGrantPermissionActivity.kt

+12 −6
Original line number Diff line number Diff line
@@ -22,6 +22,8 @@ import android.os.Build 
import android.os.Bundle

import androidx.activity.viewModels

import androidx.appcompat.app.AppCompatActivity

import androidx.lifecycle.Lifecycle

import androidx.lifecycle.flowWithLifecycle

import androidx.lifecycle.lifecycleScope

import at.bitfire.davdroid.R

import com.nextcloud.android.sso.Constants
@@ -39,7 +41,11 @@ class SsoGrantPermissionActivity: AppCompatActivity() { 
        setContentView(R.layout.activity_sso_grant_permission)



        lifecycleScope.launch {

            viewModel.event.collectLatest {

            viewModel.event

                .flowWithLifecycle(

                    lifecycle = lifecycle,

                    minActiveState = Lifecycle.State.CREATED

                ).collectLatest {

                    when (it) {

                        is SsoGrantPermissionEvent.PermissionGranted -> setSuccessResult(it.bundle)

                        is SsoGrantPermissionEvent.PermissionDenied -> setCanceledResult(it.errorMessage)