Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Add admin blacklist separate from existing lists

Akhilrequested to merge
dev/permanent-blacklist into main

Description

  • As current lists can be overwritten with automation

Screenshots

Technical details

Tests (all tests done on both signup and recovery email setting page)

  • Test case 1: Email added to admin blacklist is not allowed to be set as recovery email: ✅

  • Test case 2: Email added to admin blacklist gives "blacklisted" error message ✅

Message like "The domain of this email address is blacklisted. Please provide another recovery address." 👇 image

  • Test case 3: occ command with --list lists all admin blacklisted domains ✅

  • Test case 4: occ command with --delete deletes the given admin blacklisted domain ✅

  • Test case 5: occ command with --add adds the given admin blacklisted domain ✅

Issues

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Edited by Akhil

Merge request reports