Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9e5b837 authored by Fahim Salam Chowdhury's avatar Fahim Salam Chowdhury 👽
Browse files

chore: update lint changes based on review

parent 05e860d7

lib/Cron/TwoFactorStateChangeJob.php

+6 −5
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ class TwoFactorStateChangeJob extends QueuedJob { 
	public const ENABLED_KEY = 'enabled';

	public const USERNAME_KEY = 'username';

	public const TRYCOUNT_KEY = 'tryCount';

	private const INTERVAL_INBETWEEN_JOB_IN_SEC = 60;



	private SSOService $ssoService;

	private IJobList $jobList;
@@ -36,9 +37,9 @@ class TwoFactorStateChangeJob extends QueuedJob { 
	}



	protected function run($arguments) {

		$enabled = $arguments[$this::ENABLED_KEY];

		$username = $arguments[$this::USERNAME_KEY];

		$tryCount = $arguments[$this::TRYCOUNT_KEY];

		$enabled = $arguments[self::ENABLED_KEY];

		$username = $arguments[self::USERNAME_KEY];

		$tryCount = $arguments[self::TRYCOUNT_KEY];



		try {

			$this->ssoService->handle2FAStateChange($enabled, $username);
@@ -49,11 +50,11 @@ class TwoFactorStateChangeJob extends QueuedJob { 
			}



			$tryCount = $tryCount + 1;

			$arguments[$this::TRYCOUNT_KEY] = $tryCount;

			$arguments[self::TRYCOUNT_KEY] = $tryCount;

			$this->jobList->scheduleAfter(

				TwoFactorStateChangeJob::class,

				$arguments,

				60

				self::INTERVAL_INBETWEEN_JOB_IN_SEC

			);

		}

	}

lib/Service/SSOService.php

+2 −2
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ class SSOService { 
		$this->callSSOAPI($url, 'POST', [], 204);

	}



	public function handle2FAStateChange(bool $enabled, string $username) {

	public function handle2FAStateChange(bool $enabled, string $username) : void {

		// When state change event is fired by user disabling 2FA, delete existing 2FA credentials and return

		// i.e. disable 2FA for user at SSO

		if (!$enabled) {
@@ -174,7 +174,7 @@ class SSOService { 
		return $credentialEntry;

	}



	private function setupUserId(string $username) {

	private function setupUserId(string $username) : void {

		$user = $this->userManager->get($username);

		$savedOIDCUid = $this->config->getUserValue($user->getUID(), 'oidc_login', 'oidc_uid');