Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f486d010 authored by Ta-wei Yen's avatar Ta-wei Yen
Browse files

Relax VVM originating number matching 

The visual voicemail client can restrict the originating number for
VVM SMS to reduce false positives. The matching criteria used to be
exact match, which is too strict. Especially on CTS tests where
the formatting of the number cannot be controlled.

In this CL PhoneNumberUtils.compare() is used instead, which will
ignore formatting and country codes.

Bug: 37106950
Test: CTS android.telephony.cts.VisualVoicemailServiceTest
Change-Id: I2d28a3718b1a87f8618d171d71a08809763b9715
parent 76e7c597

src/java/com/android/internal/telephony/VisualVoicemailSmsFilter.java

+2 −1
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ import android.content.Context; 
import android.content.Intent;

import android.provider.VoicemailContract;

import android.telecom.PhoneAccountHandle;

import android.telephony.PhoneNumberUtils;

import android.telephony.SmsMessage;

import android.telephony.SubscriptionManager;

import android.telephony.TelephonyManager;
@@ -304,7 +305,7 @@ public class VisualVoicemailSmsFilter { 
        }



        for (String number : numbers) {

            if (number.equals(message.getOriginatingAddress())) {

            if (PhoneNumberUtils.compare(number, message.getOriginatingAddress())) {

                return true;

            }

        }