Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit e17a7f9e authored by Shareef Ali's avatar Shareef Ali Committed by Gerrit Code Review
Browse files

SamsungQualcommCDMARIL : fix cdma/lte signal strength implimentation

From
James Roberts		Dec 10

SignalStrength.java seems to expect 99 in response[7] in 3g, and now lte rsrp is handled directly there now. What seems to work both ways (on d2vzw at least) is:

if (response[7] == 99) {
// If LTE is not enabled, clear LTE results
// 8-11 must be -1 for cdma/evdo signal strength to be used (see
// frameworks/base/telephony/java/android/telephony/SignalStrength.java)
response[8] = -1;
response[9] = -1;
response[10] = -1;
response[11] = -1;
}

and then leave response[8] alone when response[7] != 99.

Also seems SignalStrength uses 0x7FFFFFFF for INVALID on 8, 9, 10, 11 when all values are not wanted instead of -1 but seems to work either way for me.

Sorry for the long comment. Didn't want to push up a patchset on someone else's commit in case this is wrong.

Test shows:

-104 dBm 36 asu -- LTE

-88 dBm 2 asu -- CDMA - eHRPD

Change-Id: I3c182041387a698e2928e04547989e87773ef9fa
parent 844111fe
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment