Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit b941c937 authored by Neil Fuller's avatar Neil Fuller
Browse files

Make the NitzStateMachine behavior more regular

Much of the NitzStateMachine behavior was adopted from
an understanding of how ServiceStateTracker behaved, including behavior
that didn't make complete sense.

This commit improves guarantees about when fields are set to
provide clearer post-conditions from the various "handle" methods.

Specifically, after this commit:

mLatestNitzSignal - always holds the most recently received NITZ signal.
mSavedTimeZoneId - always holds the last time zone detected.
mNitzTimeZoneDetectionSuccessful - is always set when NITZ has been used
to set the time zone.

Before this commit the statements above were not always true, depending on
the order in which events were received.

Test: atest FrameworksTelephonyTests:com.android.internal.telephony.NitzStateMachineTest
Test: atest
FrameworksTelephonyTests:com.android.internal.telephony.ServiceStateTrackerTest
Bug: 78217059
Change-Id: Ib935431cf1a0871801635894451a68a3f1702272
parent 827059f8
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment