Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit b3362121 authored by Satoshi, Baba X's avatar Satoshi, Baba X Committed by Torbjorn Eklund
Browse files

Improve correlation between log id in RILJ log and token id in modem log

Telephony FWK truncates serial number of RILJ requests to four digits
before outputting as log id in radio log. However, this truncation also
modifies the number which causes the resulting log id to have very
unclear correlation with the serial number. This serial number is used
in modem requests and will show up in modem logs in some
implementations. This commit tries to reconcile the requirement on
Telephony log with these implementations.

This patch changes the truncation to keep the last four digits in the
serial number intact in order to improve the correlation between the log
id in RILJ radio log and token id in modem log.

Prevents the serial number from becoming negative by wrapping to 0 when
reaching Integer.MAX_VALUE and preventing negative number from being
randomly generated when serial number is reset. This change ensures
that log id is always increasing when they are incremented and
truncated.

Bug: 74054019
Test: Manual
Change-Id: Ib9ee1c8f6333ecfd1105a7eb5cbe0e96c2e3c4dd
parent c79de666
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment