Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 99a3e79b authored by Brad Ebinger's avatar Brad Ebinger
Browse files

Prevent spamming hold/unhold requests in SIP

Currently, the SipPhone class assumes that a hold/unhold request is
completed successfully and does not wait for the callback from the
SipAudioCall. Since the SipCall goes into the HOLDING state without
confirmation, an unhold request may be sent before the SipAudioCall
state machine completes its transition into the HOLDING state. If an
unhold is sent to the state machine before the request completes, the
state machine will move into an invalid state and create an error,
disconnecting the call.

Until the SIP telephony code can be refactored, a temporary solution
has been added that waits for a timeout to be reached before another
request can be sent to hold/unhold a call.

Bug: 18383178
Change-Id: I540a14c0709a97dc01ef0d26d8c41712dd8c8525
parent d4c25503
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment