Fix Error Prone errors
Soong wasn't including android_app or android_test sources in the javac-check target used for the Error Prone build, which allowed some Error Prone errors to get in. Fix them so Error Prone can be re-enabled for these targets. Fixes: frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/CellIdentityNrTest.java:96: error: [TruthSelfEquals] The arguments to the isEqualTo method are the same object, so it always passes. Please change the arguments to point to different objects or consider using EqualsTester. frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/DeviceStateMonitorTest.java:115: error: [JUnit4TestNotRun] This looks like a test method but is not run; please add @test and @Ignore, or, if this is a helper method, reduce its visibility. frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/DeviceStateMonitorTest.java:66: error: [JUnit4TestNotRun] This looks like a test method but is not run; please add @test and @Ignore, or, if this is a helper method, reduce its visibility. frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/DeviceStateMonitorTest.java:90: error: [JUnit4TestNotRun] This looks like a test method but is not run; please add @test and @Ignore, or, if this is a helper method, reduce its visibility. frameworks/opt/telephony/tests/telephonytests/src/com/android/internal/telephony/imsphone/ImsPhoneTest.java:711: error: [JUnit4TestNotRun] This looks like a test method but is not run; please add @test and @Ignore, or, if this is a helper method, reduce its visibility. Bug: 146455923 Test: m RUN_ERROR_PRONE=true javac-check Change-Id: Ic6cb167adfed7342f366523952b25813ddd60c9e
Loading
Please register or sign in to comment