Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 04824aa5 authored by LuK1337's avatar LuK1337 Committed by Gerrit Code Review
Browse files

RIL: Squash changes to default SIM handling



commit 2b0a61abcb3547f502b31316eaf79bd07426338e
Author: Roman Birg <roman@cyngn.com>
Date:   Wed Jun 22 15:12:01 2016 -0700

    Subscription updater: don't turn data off if we've never set a deafult

    In the case of an MSIM device that has only had 1 SIM and then you swap
    the sim to another slot, the data will turn off, but it's the same SIM
    and should not.

    Change-Id: I77ed8c22663aa10d211e6f4de06b791c1a8f0971
Signed-off-by: default avatarRoman Birg <roman@cyngn.com>

commit 4be12e4b8cfa05e78ebc5b8e6145e43b1068ee83
Author: Roman Birg <roman@cyngn.com>
Date:   Mon Jun 20 11:13:54 2016 -0700

    Telephony: handle 3rd party sms apps + 'always ask'

    3rd party SMS apps may not be able to handle our always ask behavior, so
    they may get stuck in a bad state. An example of this is Hangouts, which
    just ends up never sending messages when always ask is selected.

    TIcket: CYNGNOS-3068

    Change-Id: I8a0f1f6bf7a5010438e40eb0be9aa178d2141f3c
Signed-off-by: default avatarRoman Birg <roman@cyngn.com>

commit 600a58b4cdfb5fe58428dc81a50629d0802f686b
Author: Roman Birg <roman@cyngn.com>
Date:   Tue May 17 17:14:44 2016 -0700

    SubscriptionInfoUpdater: improved sim swap

    We now keep track of the last number of inserted SIMs updated for. So
    when the number of SIMs has changed we do the following:

     1 sim: Clear stale defaults
            Disable SMS prompt, SMS app will default to current sim
            Disable data if the SIM left in the tray is not the one chosen

     m sim: Enable SMS prompt if we don't have a valid default (aka always
            ask)

    Furthermore, when we detect the device is an MSIM device and there is
    only one active sub, return the active sub to the UI layers (so SIM
    selection screen displays proper, grayed out, current settings).

    Ticket: CYNGNOS-2185, CYNGNOS-2570

    Change-Id: Ib1b4f4d87640e4b20722295304c58dff7dbeecbb
Signed-off-by: default avatarRoman Birg <roman@cyngn.com>

commit c8bdbb118f25dcc264b0a1c0e0fa4fbabc507f57
Author: Roman Birg <roman@cyngn.com>
Date:   Mon May 16 11:15:26 2016 -0700

    SubscriptionController: fix subscription updating

    We need to only repost messages on events we have handled, not
    prematurely posting them for every single eveng incoming.

    Furthermore, getMaxActive should return the MAX, not the current max.

    The previous fixed dual sim insertion and removal ONLY if there were two
    sims, but switching from two to one would break.

    Ticket: CYNGNOS-2185, CYNGNOS-2570

    Change-Id: I5b829662b466f609cd22adfa7d3b754757258463
Signed-off-by: default avatarRoman Birg <roman@cyngn.com>

commit 7cfda9d340bdfbb290fedf4ba378fde6c7ae2086
Author: Roman Birg <roman@cyngn.com>
Date:   Mon May 9 08:52:42 2016 -0700

    SubscriptionController: load all subs before setting defaults

    Switch the whole class to use the new inserted SIM logic added in
    change id Iab1225c83b508e055d8a8de55c1e21e2aa153ca5. The previous patch
    fixed scenarios going from two sims to one, but going from one to two
    (or switching between two sims) is still not working right as the
    addSubInfoRecord() still used getActiveSubInfoCountMax() to determine
    the number of SIMS.

     - Update getActiveSubInfoCountMax() to return the correct number of SIMs.

     - Furthermore, we need to _only_ update our subscription defaults if we
       are sure we are not in the middle of an update.

     - Let the subscription controller set defaults for 1 SIM device after
       we're done loading

    Change-Id: I28eefaff61ae7c75732641465ca59eb67cf3e198
    Ticket: CYNGNOS-2185, CYNGNOS-2570

commit bd7064dab2eebdb2d12d7d475939d733df00ff11
Author: Roman Birg <roman@cyngn.com>
Date:   Thu May 5 16:21:11 2016 -0700

    SubscriptionController: properly detect when MSIM has 1 SIM

    We cannot use sSlotIdxToSubId to determine when to turn the SIM dialog
    off, because when subscription information gets reloaded (on data change
    for instance), we may add one, then disable SMS prompt, then add the
    other, which is incorrect. Query the total number of SIMs from the info
    updater.

    Ticket: CYNGNOS-2185, CYNGNOS-2570

    Change-Id: Iab1225c83b508e055d8a8de55c1e21e2aa153ca5
Signed-off-by: default avatarRoman Birg <roman@cyngn.com>

commit ffbc7f853204869462b366b871bbd68750d30b8b
Author: Chaitanya Saggurthi <csaggurt@codeaurora.org>
Date:   Thu Feb 5 18:37:59 2015 +0530

    Add dummy SUB record in CDMA NV mode

    Add dummy SUB info record when NV is ready in CDMA NV mode.

    CRs-Fixed: 789989

    Change-Id: Ie658087efaa9f93a329773d2d8f0601d083f3701

commit 310241770efe75afcb9c8e2f219349bb90c7830f
Author: Adnan Begovic <adnan@cyngn.com>
Date:   Tue Apr 5 08:14:29 2016 -0700

    telephony: Only set prompt enabled if available subscriptions > 1.

    TICKET: CRACKLING-1026
    Change-Id: I8a7555a41a52476af5236c03b4d410dd155db390

commit b6a60870dc07640b7d4d2827de35ada3f6b289d1
Author: Adnan Begovic <adnan@cyngn.com>
Date:   Wed Mar 30 15:16:12 2016 -0700

    telephony: Workaround default sms sub id not being set.

      In the scenario where default sms sub id isn't set externally
      the user can be stuck in an endless loop of prompts if they
      select "Always Ask". This is bandaid to fix bad UX..

    TICKET: CYNGNOS-2185
    Change-Id: I70ef343eccc289d0ca58c59646f88b292ca03ca9

commit a9d1d89a3200f140cedf84e8cba97ad0ba445591
Author: LuK1337 <priv.luk@gmail.com>
Date:   Sun Sep 4 00:30:57 2016 +0200

    Readd setSMSPromptEnabled()

    Change-Id: I100a73af1c4caf68ea2c7a6a75e1f3b081947316

commit 78ef72eb88f02b4b8898d82488e5ce0af617acff
Author: Christian Morlok <ChristianMorlok@gmail.com>
Date:   Wed Jan 20 08:31:10 2016 +0100

    telephony: Do not set default subscriptions on shutdown

    On some devices the SIM slots are not deactivated at the same time
    when the phone is shut down or rebooted. This means that at some point
    only one SIM is activated, and all default subscriptions are set to
    this SIM (a feature introduced in http://review.cyanogenmod.org/#/c/121239/).

    Change-Id: Ief36004619b75530a21b23efc767e1beb1fb0750

commit 8f188ba4a878890d5c933a533162447d915494c4
Author: Ethan Chen <intervigil@gmail.com>
Date:   Mon Nov 23 17:12:47 2015 -0800

    Set default subscriptions when single SIM is available

    * Subscriptions are not updated when SIM cards are swapped. If there is
      ever a SIM count of 1, direct all defaults to point at that
      subscription, since there is no other option.

    Change-Id: Idb84140b65f3355e29cbdebcaff804318d826fe7

Change-Id: I9255eff036f3dae7607484b7f263fabbe0df813b
parent 6c903c0c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment