Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit d62330d4 authored by Harry Cutts's avatar Harry Cutts
Browse files

KeyboardInputMapper: migrate most tests to InputMapperUnitTest

Some of these tests create multiple input devices and mappers, which I
didn't have time to work out how to mimic using InputMapperUnitTest. The
rest have been migrated.

Notes:
* Split out Process_UnknownKey from Process_SimpleKeyPress, since it's a
  separate behaviour to test
* As far as I can tell, Process_KeyRemapping was just testing the
  remapping code in FakeEventHub, so I removed it
* Process_WhenNotOrientationAware_ShouldNotRotateDPad now checks for a
  display ID of DISPLAY_ID, not INVALID. This is because the method
  called by KeyboardInputMapper to check orientation
  (getAssociatedViewport) will never return an orientation without also
  returning a valid display ID; setting one without the other appears to
  have been possible in the old testing infrastructure, but would only
  have affected state somewhere outside of KeyboardInputMapper.
  For similar reasons, removed the second half of
  DisplayIdConfigurationChange_NotOrientationAware.
* MarkSupportedKeyCodes was removed, as the code to test it would have
  been too bulky to test a trivial one-liner (and it would basically
  have been a change detector).

Test: atest --host inputflinger_tests
Bug: 283812079
Flag: TEST_ONLY
Change-Id: Id6d2eb4ec2bae6bd0e9a263209169785e40a6024
parent 6e566734
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment