Fix a potential memory crash for layer debug highlighting

Move local variable to the outer scope as its pointer is used inside the vector declared in this scope.

Bug: 184392945
Test: setprop debug.sf.layer_caching_highlight property
Change-Id: I9dc8ff16e0b9aa78138141e7abeee600cc8280f0