Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 6a5dc1fa authored by Robert Carr's avatar Robert Carr
Browse files

BufferStateLayer: shouldPresentNow is always true

This method should actually be removed because we do the checking
at the transaction queue level now, but we leave it for now for
BufferQueueLayer. To show the method should always return true
we can examine each clause in the method:
	1. isVsyncValidForUid: We were supposed to check this at
	transaction queue, if for some reason this returned false
	now we just need to continue.
	2. getSideBandStream/AutoRefresh, covered by the call to
	layer->hasReadyFrame which encloses the only call to
	layer->shouldPresentNow
	3. hasFrameUpdate, also called by layer->hasReadyFrame
	4. isBufferDue, supposed to be handled by the transaction
	queue, mismatch not allowed at this point.
Just landing this to simplify debugging around this codepath.

Bug: 180194022
Test: Existing tests pass
Change-Id: I1a5eb572a3e651a2504039ef9cc8e3b51a46dd3c
parent a170ec6a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment