BufferStateLayer: shouldPresentNow is always true
This method should actually be removed because we do the checking at the transaction queue level now, but we leave it for now for BufferQueueLayer. To show the method should always return true we can examine each clause in the method: 1. isVsyncValidForUid: We were supposed to check this at transaction queue, if for some reason this returned false now we just need to continue. 2. getSideBandStream/AutoRefresh, covered by the call to layer->hasReadyFrame which encloses the only call to layer->shouldPresentNow 3. hasFrameUpdate, also called by layer->hasReadyFrame 4. isBufferDue, supposed to be handled by the transaction queue, mismatch not allowed at this point. Just landing this to simplify debugging around this codepath. Bug: 180194022 Test: Existing tests pass Change-Id: I1a5eb572a3e651a2504039ef9cc8e3b51a46dd3c
Loading
Please register or sign in to comment