Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 9bd23229 authored by Jean-Michel Trivi's avatar Jean-Michel Trivi
Browse files

Fix multichannel downmix pause bug on video player

Pausing a video player will cause the track audio mixer to be
 disabled, which causes the downmixer to be deleted. When reenabled,
 the track channel mask hasn't changed but the downmixer is there
 anymore.
Fixed by:
- instanciating a downmixer when the AudioMixer track
 gets initialized (in getTrackName(), now taking a channel mask
 as input), and deleted when in deleteTrackName().
- when the channel changes on a track, check whether it
 needs a downmixer or not. Preparing a track for downmix
 automatically removes the old downmixer if there was one.

Also: initialize the track downmixerBufferProvider field
 when AudioMixer is instanciated, so we can safely call
 delete on it in AudioMixer's destructor, in case
 deleteTrackName() wasn't called before the mixer was
 destroyed.

Change-Id: I589b0781cda5b3c82f85b561c52b08546cac21f8
parent 0ca3cf94
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment