Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 7cb0c2d8 authored by Nick Kralevich's avatar Nick Kralevich
Browse files

Revert "libstagefright: remove left shifts causing unsigned int overflow"

Causing the following build breakage:

frameworks/av/media/libstagefright/codecs/mp3dec/src/pvmp3_get_side_info.cpp:113:58: error: suggest parentheses around '-' inside '<<' [-Werror=parentheses]
 #define mask_and_shift(tmp, a, b) ((tmp >> (b - a)) & (1 << (32 - b) - 1))
                                                          ^
frameworks/av/media/libstagefright/codecs/mp3dec/src/pvmp3_get_side_info.cpp:222:52: note: in expansion of macro 'mask_and_shift'
             si->ch[ch].gran[0].part2_3_length    = mask_and_shift(tmp, 11, 20);   /* 12 */
                                                    ^
frameworks/av/media/libstagefright/codecs/mp3dec/src/pvmp3_get_side_info.cpp:113:58: error: suggest parentheses around '-' inside '<<' [-Werror=parentheses]
 #define mask_and_shift(tmp, a, b) ((tmp >> (b - a)) & (1 << (32 - b) - 1))
                                                          ^
frameworks/av/media/libstagefright/codecs/mp3dec/src/pvmp3_get_side_info.cpp:223:52: note: in expansion of macro 'mask_and_shift'
             si->ch[ch].gran[0].big_values        = mask_and_shift(tmp, 23, 23);   /*  9 */
                                                    ^

This reverts commit 18d5c836.

Change-Id: I64fc05f92ffb22b79575ecc978d8b2bc2a95c5cc
parent 18d5c836
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment