Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 634d6953 authored by Atneya Nair's avatar Atneya Nair
Browse files

Remove handle clear on binder death

There is no compelling reason to clear the IEffect handle upon binder
death. Our method calls return fails regardless, and we do not null
check the handle. The notification is also synchronous with existing
calls, leading to a racy use-after-free (sp is not thread-safe). Rather
than incurring the cost of locking, holding onto the handle is fine, as
it is not expensive, and the object will likely be destroyed soon.

Test: Compiles
Bug: 223537153
Change-Id: Id5577d50f0e91c946ef37fde33e3834fec0ca676
(cherry picked from commit ece853f3)
Merged-In: Id5577d50f0e91c946ef37fde33e3834fec0ca676
parent 6ca7e5d7
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment