Commit fe85fa16 authored Apr 11, 2017 by Amit Pundir Committed by Vincent Zvikaramba Feb 17, 2018

ANDROID: Skip building uid_sys_stats and keyreset drivers as modules



Few Android drivers viz. uid_sys_stats and keyreset/combo fail to
build as kernel modules.

uid_sys_stats.ko failed for undefined "tasklist_lock", which got
un-exported in commit c59923a1 ("remove the tasklist_lock export").
Quoting from the commit, "Modules have  no business looking at it,
and all instances in drivers have been due to use of too-lowlevel
APIs. Having this symbol exported prevents moving to more scalable
locking schemes for the task list.". So instead of exporting
tasklist_lock again, lets not build uid_sys_stats driver as module.
Similarly skip building keyreset driver as module which call
sys_sync() syscall.

To keep things in perspective we don't build these drivers as modules
in later kernels (android-4.4/4.9) as well.

Change-Id: I6371df72d79c7ad0f0c08e6ebf7e16f1b0970761
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>

parent f6ce300f

drivers/input/Kconfig

+1 −4

Original line number	Diff line number	Diff line
		@@ -175,15 +175,12 @@ config INPUT_APMPOWER
		module will be called apm-power.

		config INPUT_KEYRESET
		tristate "Reset key"
		bool "Reset key"
		depends on INPUT
		select INPUT_KEYCOMBO
		---help---
		Say Y here if you want to reboot when some keys are pressed;

		To compile this driver as a module, choose M here: the
		module will be called keyreset.

		config INPUT_KEYCOMBO
		tristate "Key combo"
		depends on INPUT

drivers/misc/Kconfig

+1 −1

Original line number	Diff line number	Diff line
		@@ -672,7 +672,7 @@ config SRAM
		areas found on many SoCs.

		config UID_SYS_STATS
		tristate "Per-UID statistics"
		bool "Per-UID statistics"
		depends on PROFILING
		help
		Per UID based cpu time statistics exported to /proc/uid_cputime