Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit fcea656f authored by David Collins's avatar David Collins
Browse files

bif: qpnp-bsi: request BSI interrupts with level high triggering



Request the BSI RX, TX and ERR interrupts using level high
triggering instead of rising edge triggering.  If an interrupt
is edge triggered, then its interrupt handler will be called upon
enabling the interrupt if it physically triggered while it was
disabled in software.  This leads to unexpected interrupt
handler calls in the qpnp-bsi driver when the following sequence
occurs: BIF transaction using interrupts (IRQs enabled), BIF
transaction using polling (IRQs disabled), BIF transaction to
enter interrupt mode bus state (IRQs enabled).

Switching the interrupts to use level triggering fixes the issue
because any interrupt physically triggered during a polling
transaction with the BSI interrupts disabled will be ignored by
the irq framework.

Change-Id: I57a6fb6f75af14970b5a186009ec506e240c151d
Signed-off-by: default avatarDavid Collins <collinsd@codeaurora.org>
parent 069376c1
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment