Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Unverified Commit f2aa03f9 authored by Ilya Dryomov's avatar Ilya Dryomov Committed by Harsh Shandilya
Browse files

libceph: don't bail early from try_read() when skipping a message



commit e7a88e82fe380459b864e05b372638aeacb0f52d upstream.

The contract between try_read() and try_write() is that when called
each processes as much data as possible.  When instructed by osd_client
to skip a message, try_read() is violating this contract by returning
after receiving and discarding a single message instead of checking for
more.  try_write() then gets a chance to write out more requests,
generating more replies/skips for try_read() to handle, forcing the
messenger into a starvation loop.

Reported-by: default avatarVarada Kari <Varada.Kari@sandisk.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
Tested-by: default avatarVarada Kari <Varada.Kari@sandisk.com>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 06cdb6d6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment