wil6210: fix for unreachable code in wmi_recv_cmd
As reported by Dan Carpenter <dan.carpenter@oracle.com>: The patch a715c7ddd65a: "wil6210: improve debug for WMI receive" from May 29, 2014, leads to the following static checker warning: drivers/net/wireless/ath/wil6210/wmi.c:746 wmi_recv_cmd() info: ignoring unreachable code. drivers/net/wireless/ath/wil6210/wmi.c 739 spin_unlock_irqrestore(&wil->wmi_ev_lock, flags); 740 { 741 int q = queue_work(wil->wmi_wq, 742 &wil->wmi_event_worker); 743 wil_dbg_wmi(wil, "queue_work -> %d\n", q); 744 } 745 } 746 if (n > 1) ^^^^^^^^^^ We never reach this if statemtent. 747 wil_dbg_wmi(wil, "%s -> %d events processed\n", __func__, n); 748 } Exit loop with "break", not "return". Change-Id: Iafa9244efbdb3f1bf92459a2cc61669719d39063 Reported-by:Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> Signed-off-by:
John W. Linville <linville@tuxdriver.com> Git-commit: 95266dc07d52b28d7cedb755e2ff4254bb2d7eec Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git Signed-off-by:
Hamad Kadmany <hkadmany@codeaurora.org>
Loading
Please register or sign in to comment