Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 301da258 authored by Jack Pham's avatar Jack Pham
Browse files

Revert "usb: dwc3-msm: Resume SS_PHY after enabling clocks"



This reverts commit dbc6a719.

By moving the SS_PHY resume to before enabling clocks, this has
the added benefit of improving the QMP SS PHY LFPS handshake
response by about 1.5-2.0ms and thus decreases overall resume time.
However, for QSCRATCH-based PHYs care must be taken to ensure
that the USB3 controller master clock is turned on or else its
usb_phy_set_suspend() routine will encounter unclocked register access.

Two previous changes, commit e6572b0 "clock: msm: Add
gcc_usb30_master_clk to USB HS/SS PHY devices", and commit c7852f6c
"usb: phy-msm-ssusb: Add USB3 core clock" allow the QSCRATCH SS PHY
driver to now properly handle set_suspend() being called even when
the USB3 hasn't yet enabled its clocks.  Thus we can now move the
usb_phy_set_suspend() back to its previous spot.

Change-Id: I12323c6b8304d4ed35adf7e5ecb40c50116be704
Signed-off-by: default avatarJack Pham <jackp@codeaurora.org>
parent c7852f6c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment