KVM: x86: fix deadlock in clock-in-progress request handling
There is a deadlock in pvclock handling:
cpu0:                                               cpu1:
kvm_gen_update_masterclock()
                                              kvm_guest_time_update()
 spin_lock(pvclock_gtod_sync_lock)
                                               local_irq_save(flags)
spin_lock(pvclock_gtod_sync_lock)
 kvm_make_mclock_inprogress_request(kvm)
  make_all_cpus_request()
   smp_call_function_many()
Now if smp_call_function_many() called by cpu0 tries to call function on
cpu1 there will be a deadlock.
Fix by moving pvclock_gtod_sync_lock protected section outside irq
disabled section.
Analyzed by Gleb Natapov <gleb@redhat.com>
Acked-by:  Gleb Natapov <gleb@redhat.com>
Reported-and-Tested-by:
Gleb Natapov <gleb@redhat.com>
Reported-and-Tested-by:  Yongjie Ren <yongjie.ren@intel.com>
Signed-off-by:
Yongjie Ren <yongjie.ren@intel.com>
Signed-off-by:  Marcelo Tosatti <mtosatti@redhat.com>
Marcelo Tosatti <mtosatti@redhat.com>
Loading
Please register or sign in to comment
