Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83159e34 authored by Daniel Rosenberg's avatar Daniel Rosenberg Committed by Usaamah Patel
Browse files

ANDROID: xattr: Pass EOPNOTSUPP to permission2 



The permission call for xattr operations happens regardless of
whether or not the xattr functions are implemented.

The xattr functions currently don't have support for permission2.
Passing EOPNOTSUPP as the mount point in xattr_permission allows
us to return EOPNOTSUPP early in permission2, if the filesystem
supports it.

Change-Id: I9d07e4cd633cf40af60450ffbff7ac5c1b4e8c2c
Signed-off-by: default avatarDaniel Rosenberg <drosen@google.com>
Bug: 35848445
parent e330814c

fs/sdcardfs/inode.c

+2 −0
Original line number Diff line number Diff line
@@ -637,6 +637,8 @@ static int sdcardfs_permission(struct vfsmount *mnt, struct inode *inode, int ma 
	struct inode tmp;

	struct sdcardfs_inode_data *top = top_data_get(SDCARDFS_I(inode));



	if (IS_ERR(mnt))

		return PTR_ERR(mnt);

	if (!top)

		return -EINVAL;

fs/xattr.c

+1 −1
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ xattr_permission(struct inode *inode, const char *name, int mask) 
			return -EPERM;

	}



	return inode_permission(inode, mask);

	return inode_permission2(ERR_PTR(-EOPNOTSUPP), inode, mask);

}



/**