Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Feature/#40 code refactoring

Description

Before starting work on the logs, it was important to have a clean code.

  • Agent instructions
  • errorManager.js should be error.manager.js
  • viewManager.js should be view.manager.js
  • vue folder should be view folder
  • using class utilities in downloader.manager.js to avoid overloaded functions
  • using subfunctions & "enums" to improve readability
  • add missing descriptions
  • move DOM listener in a same file app/src/view/listener.manager.js
  • remove unused async onNext($button) onADBConnect() onWaiting() in app/src/viewManager.js

No functional changes have been made, only refacto

Screenshots

Technical details

Tests

Issues

https://gitlab.e.foundation/e/devices/eos-installer/-/work_items/40

10 commandments of code review

👪 ❤️ code review guidelines

Merge request reports

Loading