Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

issues 249 & 254 & 289 : add version of easy-installer in feedbacks

Vincent Bourgmayer requested to merge 254-issue into master

move version number to AppConstats.java and use it in FeedbackController.java to send easy-installer version with feedback.

Modify feedback view, to display all feedback content in commentArea, update "send" button's text and add a label under it to specify data are not identifiable.

Closes #254 Closes #249 Closes #289

HOW TO TEST

  • You can make a quick test if you have no time, by testing this branch:

https://gitlab.e.foundation/e/tools/easy-installer/-/tree/249-issue-quickTest

Note: This is a modified version of the installer that just run the device detection view. Once your device is detected, you can click on continue and you'll directly go in "Feedback" view. So you don't have to flash your device and follow the full process.

  • Or you can run the easy-installer until the end with this branch:

https://gitlab.e.foundation/e/tools/easy-installer/-/tree/254-issue

1. Check horizontal padding of button's text is setted

It must looks like that:

image

and not like that:

image

2. Check that feedback's view (last view) displays fixed content of a feedback:

  • date of the feedback
  • device's model
  • Easy-installer version
  • Host OS
  • Feelings of the user (not selected by default)

example:

image

3. Check that selecting feelings update the value of "Feelings" in the fixed content of the feedback

example: image

image

4. Fill the comment's text area with info that indicate that your are validate the MR (so I could recognize it's you) and send the feedback. Told that you send a feedback so I could check I recieve it

Edited by Vincent Bourgmayer

Merge request reports

Loading