Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Add FP3 support

Ingo requested to merge Ingo-FP-Angel/easy-installer:fp3 into master

This add support for the Fairphone 3 to the easy installer.

@TODO:

TODO

  • create YAML files for FP3
  • add necessary flash scripts
    • linux/mac
    • windows
  • add ways to unzip installation archive
    • also package jar executable
  • test flash scripts
    • linux
    • mac
    • windows
  • make installer wait for unlocking
    • because there is no step in recovery as with other phones, the installer continues before the user can confirm the unlock step on the FP3
  • test installer when running in IDE
    • linux
    • mac
    • windows
  • test some edge cases
    • bootloader already unlocked
      • if bootloader already unlocked, don't tell to reboot
    • not unlocking the device in step 2
    • with stock ROM installed in both slots (I already had /e/ installed during testing)
  • make wipe work in packaged installer
    • error is
      • /x01/user/ingo/FP3/eelo/linux-installer/bin/adb/mke2fs failed with status 1
      • fastboot: error: Cannot generate image for userdata
    • have to package mke2fs as well
  • test packaged installer
    • linux
    • linux (snap)
    • mac
    • windows
  • handle unlock code
    • not necessary: calculate code and use in OEM unlocking step
    • optional: probably show calculated code to the user
    • as my FP3 doesn't need an unlock code, somebody else has to verify it works
  • improve instructions
    • some hint to do the OEM unlocking on the phone
    • some hint how to best boot into fastboot mode after unlocking (or not to do anything when the bootloader was already unlocked)
  • add translations
    • new entries so far only in translation.properties, not the language specific ones
  • add instructional images
    • for now I have removed all titleIcon and instructionImg entries in FP3_fs.yml
    • seems the instructionImg is not shown
    • I don't know what the titleIcon is supposed and which icon set to use in case I want to add one
  • check the pipeline status

Known problems

  • There is no 'Continue' to click for the option that I already have an /e/ account at the end
    • already reported here: e/backlog#1296 (closed)
    • in plenty of tests I actually had the 'Continue' button once, not sure about the exact circumstances when it appears (seems like it helps to switch back and forth between the two options)

Ideas for later

  • automatically reboot to fastboot mode via adb for step 1
  • somehow handle device 'unauthorized'
    • maybe by adding a hint to the screen while trying to detect the phone
Edited by Romain Hunault

Merge request reports

Loading