Resolve "Implement new UI and controllers" (!130) · Merge requests · e / devices / Easy Installer

Vincent Bourgmayer requested to merge 362-issue into master Sep 27, 2021

Description

This MR is a part of a big refactoring of Easy-installer. In previous MR, the config file which describe the flashing process has been changed. This MR brings a new way to build & load UI (for flashing process only: after source downloading step) and to go through different flashing's step.

The goal of this MR isn't to add new behaviour or functionality. However, it might fix some UI issues.

Issue(s)

Closes #362

Test environment

non regression test

/!\ Checked OS should at least be tested: /!\

windows
linux
MacOS Not supported yet_

/!\ Checked devices should at least be tested: /!
If no device checked, then you can pick anyone from the list

HOW TO SETUP

Download build from latest pipeline of this MR

windows

Extracted Installer from the build downloaded
Double click on it
Follow the setup wizard
Start from shorcut in menu

linux with Snap

You need to have snap available from your shell.

Debian/ubuntu based :
```
sudo apt install snapd
```
Fedora based :
```
sudo dnf install snapd
```

Arch linux based :

yaourt -S snapd
sudo systemctl enable --now snapd.socket

Extract snap file to some location
Open shell prompt and move to this location (using cd )
run : sudo snap install --dangerous <yourFile.snap>. Note: I have a doubt about sudo
run : snap connect easy-installer:adb-support
run : sudo snap connect easy-installer:raw-usb

Uninstall the easy-installer test build:

Windows:

Open menu
Right click on easy-installer
select uninstall

Or remove it like any other software from uninstall settings menu.

Linux:

run sudo snap remove easy-installer in a shell

Test procedures

Tests to validate this merge request only cover the part after the downloading of sources. Any problem discover before that, isn't relative to this MR. Please report it anyway, but consider they're not blocking for the validation.
This MR isn't about translation. If you see incorrect translation please report, but they aren't blocking for the validation.
Ignore the 'account creation" step before the last step of flashing process.
Once you reach the end of the flashing process, you can leave. The 2-3 last UI aren't in this MR's area.

To confirm this MR you will have to flash device at least 3-4 times.

For every step, please check:

You can display log panel by clicking on the "V Log" button at the bottom center of the UI
If you display the log Panel, you can hide it by clicking on the "> button" above the log part of the screen
When you move to the next step, the current UI fade out and the next step UI fade in.
At the top of the screen, there is a kind of progress bar made of differement segment. It represents the progress over the general process. Each step has a fragment: green if succesful, blue if current and grey if not done yet.

For the 3 step types please check the following:

Step with instructions without script to run

There is a title above the instruction
At begining the top instruction is focused (blue background, white text). Most of the time a picture is displayed right to the text, to illustrate.
When you click on continue, the previously focused instruction lost focus and the next instruction is focused (blue background, white text). The picture will change if the new focused step has a bound picture or disappear if no picture.
When you reach the last instruction and click on continue you will move to the next step.

Note: If a focused instruction don't have picture, but the next have one, you may see a problem with the focused instruction. This isn't relative to this MR. An issue is already open about it.

Step with instructions with script to run

There is a title above the instruction
At beginning the top instruction is focused (blue background, white text). Most of the time a picture is displayed right to the text, to illustrate.
When you click on continue, the previously focused instruction lost focus and the next instruction is focused (blue background, white text). The picture will change if the new focused step has a bound picture or disapear if no picture.
When you reach the last instruction, the "continue" button must be hidden. You must wait for the script to finish to reach the next step.
If the running script failed, the instructions (and pictures) are replaced by an error message and a "Try again" button which will restart the whole flashing process.
If the running script failed and you click on "continue", you will reach the "feedback" UI.

Note: If a focused instruction don't have picture, but the next have one, you may see a problem with the focused instruction. This isn't relative to this MR. An issue is already open about it.

Step with script and progress bar. User have to wait.

"Continue" button is hidden
There is a title above the progress bar
The progress bar will load in a defined time.
If the running script failed, the progress bar will stop and become red (instead of green). An error message and a "Try again" button will appear under it. If you click on Try Again you will restart the whole flashing process.
If the running script failed, the continue button will appear. If click on it, you will move to the "feedback" UI.
When the script finished and succeed you will move the next step automatically.

They must all be displayed correctly (see screenshot in section below)

There is no specific way to produce an error in a script. Tell me which device you use and I will you what to do, or I will make a special build which fails at expected step.