Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db41b87d authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Jeff Kirsher
Browse files

igb: Fix memory leak in igb_get_module_eeprom() 



Fix a memory leak in the igb_get_module_eeprom() error handling path.
Detected by Coverity: CID 1016508.

Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Tested-by: default avatarJeff Pieper <jeffrey.e.pieper@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 22a8b291

drivers/net/ethernet/intel/igb/igb_ethtool.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -2791,9 +2791,11 @@ static int igb_get_module_eeprom(struct net_device *netdev, 
	/* Read EEPROM block, SFF-8079/SFF-8472, word at a time */

	/* Read EEPROM block, SFF-8079/SFF-8472, word at a time */

	for (i = 0; i < last_word - first_word + 1; i++) {

	for (i = 0; i < last_word - first_word + 1; i++) {

		status = igb_read_phy_reg_i2c(hw, first_word + i, &dataword[i]);

		status = igb_read_phy_reg_i2c(hw, first_word + i, &dataword[i]);

		if (status != E1000_SUCCESS)

		if (status != E1000_SUCCESS) {

			/* Error occurred while reading module */

			/* Error occurred while reading module */

			kfree(dataword);

			return -EIO;

			return -EIO;

		}





		be16_to_cpus(&dataword[i]);

		be16_to_cpus(&dataword[i]);

	}

	}