Commit db382d47 authored Oct 15, 2024 by Wang Hai Committed by Harshit Mogalapalli Feb 07, 2025

net/sun3_82586: fix potential memory leak in sun3_82586_send_packet()



[ Upstream commit 2cb3f56e827abb22c4168ad0c1bbbf401bb2f3b8 ]

The sun3_82586_send_packet() returns NETDEV_TX_OK without freeing skb
in case of skb->len being too long, add dev_kfree_skb() to fix it.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Message-ID: <20241015144148.7918-1-wanghai38@huawei.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 137010d2)
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>

parent 531aa0f0

drivers/net/ethernet/i825xx/sun3_82586.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1013,6 +1013,7 @@ static int sun3_82586_send_packet(struct sk_buff skb, struct net_device dev)
		if(skb->len > XMIT_BUFF_SIZE)
		{
		printk("%s: Sorry, max. framelength is %d bytes. The length of your frame is %d bytes.\n",dev->name,XMIT_BUFF_SIZE,skb->len);
		dev_kfree_skb(skb);
		return NETDEV_TX_OK;
		}